New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH2696: Update Cake support for GitReleaseManager #2699
Commits on Jan 22, 2020
-
(cake-buildGH-2696) Use common base class for settings
Not entirely sure what this wasn't done initially, but I think it makes sense to apply this refactoring now. Makes it easier to add the three new common options.
Configuration menu - View commit details
-
Copy full SHA for bb31672 - Browse repository at this point
Copy the full SHA bb31672View commit details -
(cake-buildGH-2696) Add new common base options
All of these will default to false, unless otherwise specified.
Configuration menu - View commit details
-
Copy full SHA for 0d5d925 - Browse repository at this point
Copy the full SHA 0d5d925View commit details -
Add indentation which seemed to be missing
Configuration menu - View commit details
-
Copy full SHA for e64620b - Browse repository at this point
Copy the full SHA e64620bView commit details -
(cake-buildGH-2696) Add obsolete attributes to aliases
GitReleaseManager is deprecating support for using username/password when connecting to GitHub, and as such, the Cake Aliases that provide this functionality should also be marked as Obsolete.
Configuration menu - View commit details
-
Copy full SHA for 1d21363 - Browse repository at this point
Copy the full SHA 1d21363View commit details -
(cake-buildGH-2696) Add common options with tests
Add parsing of common arguments to each alias for GitReleaseManager, as well as tests for ensuring that they are being output when set.
Configuration menu - View commit details
-
Copy full SHA for db1f7e5 - Browse repository at this point
Copy the full SHA db1f7e5View commit details -
(cake-buildGH-2697) Update to latest GRM
Update tool pre-processor directive to use 0.10.2. Also switch away from using username/password version GRM Cake aliases, in favour of token version. And finally, added yaml configuration to enable new GRM features.
Configuration menu - View commit details
-
Copy full SHA for a2be9d0 - Browse repository at this point
Copy the full SHA a2be9d0View commit details -
(cake-buildGH-2696) Add discard and open methods
These were created by copying from the create and close methods.
Configuration menu - View commit details
-
Copy full SHA for 46c5ff4 - Browse repository at this point
Copy the full SHA 46c5ff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b42c8 - Browse repository at this point
Copy the full SHA f7b42c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac34832 - Browse repository at this point
Copy the full SHA ac34832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 019bf66 - Browse repository at this point
Copy the full SHA 019bf66View commit details -
(cake-buildGH-2696) Switch to AppendQuotedSecret
Not sure how/why this wasn't implemented already across all the methods, but glad that it was caught here.
Configuration menu - View commit details
-
Copy full SHA for b359473 - Browse repository at this point
Copy the full SHA b359473View commit details