Bug in checking private variables. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private variables require double underscore (__), however the isValidVar does not account for private variables. It only allows for protected variables with a single underscore. This will resolve the private variable check.
|
What's going on with the whitespace? Also I don't see where |
Updated the usage for $firstStringCount
|
Added $firstStringCount on line 280 where it is removing the first character. The issue is if you pass a private variable here, it will leave a leading underscore and give you an error indicating it does not match the camel case. I updated line 280 so it would reflect the change for $firstStringCount if (preg_match("|[^$legalChars]|", substr($string, $firstStringCount)) > 0) { |
markstory
added a commit
that referenced
this pull request
Apr 3, 2012
Bug in checking private variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private variables require double underscore (__), however the isValidVar does not account for private variables. It only allows for protected variables with a single underscore. This will resolve the private variable check by changing the number of characters to remove from the beginning of the string before checking legalChars.