Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeHelper format method expects date formats in the ICU format #6137

Closed
rawroland opened this issue Mar 22, 2015 · 1 comment
Closed

TimeHelper format method expects date formats in the ICU format #6137

rawroland opened this issue Mar 22, 2015 · 1 comment
Assignees
@lorenzo
Labels
documentation
Milestone
3.0.3

Comments

@rawroland
Copy link

The documentation for the format method does not mention the expected format, which is the ICU format. This may lead to confusion.
@lorenzo lorenzo added this to the 3.0.0 milestone Mar 22, 2015
@lorenzo lorenzo self-assigned this Mar 22, 2015
@lorenzo
Copy link
Member

lorenzo commented Mar 22, 2015

Actually the format for format() is the default PHP one. The format from ICU is only valid for the methods that output locale-aware strings. I will try to make this more clear in the docs.

@markstory markstory modified the milestones: 3.0.0, 3.0.1 Mar 23, 2015
@markstory markstory modified the milestones: 3.0.1, 3.0.2 Apr 5, 2015
@markstory markstory modified the milestones: 3.0.2, 3.0.3 Apr 20, 2015
@lorenzo lorenzo mentioned this issue Apr 29, 2015
Closed
@lorenzo lorenzo closed this as completed Apr 29, 2015
markstory added a commit that referenced this issue May 1, 2015
@markstory
Update docs for TimeHelper
6528df6 
Refs #6137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo lorenzo

Labels
documentation
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
3 participants
@markstory @lorenzo @rawroland