Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the difference between format() and other methods in Time #2685

Closed
lorenzo opened this issue Apr 29, 2015 · 4 comments
Closed

Explain the difference between format() and other methods in Time #2685

lorenzo opened this issue Apr 29, 2015 · 4 comments
Assignees
Milestone

Comments

@lorenzo
Copy link
Member

lorenzo commented Apr 29, 2015

The format from ICU is only valid for the methods that output locale-aware strings, but some people try to use format() as if it were ICU aware.

Refs cakephp/cakephp#6137

@lorenzo lorenzo added this to the 3.0 milestone Apr 29, 2015
@markstory markstory self-assigned this Apr 29, 2015
@markstory
Copy link
Member

Should format() also accept ICU constants?

@lorenzo
Copy link
Member Author

lorenzo commented Apr 29, 2015

that would be even more confusing, imo

@markstory
Copy link
Member

Ok.

@markstory
Copy link
Member

Closing this as the original issue was for TimeHelper which aliases format() to be the i18nFormat method. This is a bit silly, but TimeHelper has always been a bit silly. I'll update the relevant doc block on TimeHelper instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants