Add rotation

[bootstraponline]

Fix #133

Example spec.

@spec
Scenario: Rotate everything
  Then I wait for 15 seconds
    And I rotate the device to portrait
    And I wait for 5 seconds
    And I rotate the device to landscape
    And I wait for 5 seconds
    And I rotate the device to portrait
    And I wait for 5 seconds
    And I rotate the device to landscape

[jonasmaturana]

The problem with this approach is that it works on activity level and not on a device level and therefore the behavior is pretty far from the user experience.

The consequence is that:

• The event sequence is not the same as when you rotate the device.
• When you go to another activity the app orientation returns to portrait.

Currently I don't think this belongs in the official project because of all the confusion it will cause.

I think a better solution would be to make the emulator rotate like when when you use 7 and 9.

[bootstraponline]

Calabash currently provides nothing for rotation. Robotium has setActivityOrientation which some people have found useful and is better than nothing.

Sending key presses to the emulator depends on using OS specific APIs to focus the Android emulator and then send the key press. I don't think that's ideal.

Telling people that rotation is exclusive to the expensive LessPainful device cloud is not cool. Surely there's some way to add this in a way that doesn't cause confusion.

[jonasmaturana]

We try to keep everything in calabash working like something an user would do to the app.

It could give value to some people that we add "set_activity_orientation" to the api I just want it to be very clear that using that api is not simulating user input very well. Also, I don't think a predefined step is suitable for something as low level as this.

I'm sorry if I made the impression that I don't want to include something like rotation into calabash because we want something extra on lesspainful.com because that's really not the case. We want calabash to be as powerful as possible.
The reason we added device rotation to our service is not because we enjoy playing with servos but because we worked with customers who used setActivityOrientation and it didn't work for them.

[bootstraponline]

It could give value to some people that we add "set_activity_orientation" to the api I just want it to be very clear that using that api is not simulating user input very well.

Adding set_activity_orientation to the API would be nice.

I'm sorry if I made the impression that I don't want to include something like rotation into calabash because we want something extra on lesspainful.com because that's really not the case. We want calabash to be as powerful as possible.

Thanks for the explanation.

[bootstraponline]

@jonasmaturana What do you think of this commit? I've removed the predefined step.

[bootstraponline]

Have you had a chance to look at the new rotation code?

[jonasmaturana]

I have been looking at the code.

I would like to merge the new action but I think the key should be set_activity_orientation.
The changes to rotation_steps.rb and operations.rb I will not merge because I think they will confuse people.

[bootstraponline]

I have been looking at the code.

You're looking at the new code from https://github.com/calabash/calabash-android/pull/143/files? It seems as if your comments are based on the old code. I replaced the code 12 days ago and eliminated the rotation changes in favor of set_activity_orientation.

I'm happy to make additional changes for this to be merged.

[bootstraponline]

Let me know if changes are required. The key has already been updated.