Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Core#scroll methods #1189

Merged
merged 7 commits into from Oct 4, 2016

Conversation

jmoody
Copy link
Member

@jmoody jmoody commented Oct 3, 2016

Motivation

The previous implementation of the #scroll_to* methods would, but default, try to scroll on every matching UIScrollView subclass. This behavior was unpredictable and expensive (time).

The default to behavior is to scroll the first matching scroll view. This behavior is in line with the original documentation. The documentation has been updated to stress that matching multiple scroll views will have unpredictable behavior.

This changeset also includes an interface to the new scrollToMark operation.

      # Scrolls to a mark in a UIScrollView.
      #
      # Make sure your query matches exactly one UIScrollView.  If multiple
      # scroll views are matched, the results can be unpredictable.
      #
      # @example
      #  scroll_to_mark("settings")
      #  scroll_to_mark("Android", {:animated => false})
      #  scroll_to_mark("Alarm", {:query => "UIScrollView marked:'Settings'"})

Other changes

  • improved client side argument checking
  • specs for most of the scroll_to* API

JIRA

@jmoody jmoody added this to the 0.20.3 milestone Oct 3, 2016
@jmoody jmoody self-assigned this Oct 3, 2016
@jmoody
Copy link
Member Author

jmoody commented Oct 4, 2016

Console methods are failing on Jenkins. Will address in a subsequent pull request.

@jmoody jmoody merged commit 689c573 into develop Oct 4, 2016
@jmoody jmoody deleted the feature/update-the-Core-scroll-methods branch October 4, 2016 10:58
@jmoody jmoody mentioned this pull request Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant