call to strings in gem/server compatibility should work on paths with spaces
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK! -1 to me. Thanks for the fix. What was happening? Was there a crash? |
|
There was no crash, but on my system strings emitted around 200 lines of
|
jmoody
changed the title
strings in gem/server compatibility should work on paths with spaces
jmoody
added a commit
that referenced
this pull request
May 29, 2014
call to `strings` in gem/server compatibility should work on paths with spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app I test has a space in the name so the resulting APP_BUNDLE_PATH looks like "/users/sqeaky/wherever/xcode/leaves/app/App Name.app". The space causes strings to see this as two filenames "/users/sqeaky/wherever/xcode/leaves/app/App" and "Name.app". Wrapping that in quotes makes strings interpret this as one argument and allows it to work correctly.
This was tested on Mac OS X 10.8 with XCode 5.1.1 and produced no warnings or error messages.