Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is having the binaries in the features/prebuilt a good practice? #196

Closed
jmoody opened this issue Jul 31, 2015 · 1 comment
Closed

Is having the binaries in the features/prebuilt a good practice? #196

jmoody opened this issue Jul 31, 2015 · 1 comment

Comments

@jmoody
Copy link
Contributor

jmoody commented Jul 31, 2015

See samples/wordpress

I am concerned that it will lead to the binary being uploaded 2x to the XTC - once because it was passed as an argument and again because it is in features/.

From a workflow perspective it is not great when using tools like vim and emacs - too many autocomplete matches (control-p on vim, c-x c-f on emacs).

It is also confusing because I believe the expectation is that the binaries will be outside the features directory. Walking up to the repo, I didn't know where the binaries where. A README.md will sort that (I will write one now).

@krukow @olefriis Can you comment on the uploading 2x issue?

cc @TobiasRoikjer

@TobiasRoikjer
Copy link
Contributor

@jmoody I agree on this actually. Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants