Replace find(event) with find(event.id) in spec #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the deprecation warning thrown when running parser_ical_spec.rb by passing event.id to find rather than passing event itself to find.
|
Would |
Replace find(event) with event.reload since the intent is to check if the times were saved to the database properly.
|
I agree. It does seem to make more sense to use event.reload here. |
reidab
added a commit
that referenced
this pull request
Jul 4, 2015
Replace find(event) with find(event.id) in spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the deprecation warning thrown when running parser_ical_spec.rb by
passing event.id to find rather than passing event itself to
find.