Spaces are missing in languages list (UnitedStates UnitiedKingdom) #712
Comments
|
About "NorweiganBokmal (Norway)": |
|
This is actually a Qt bug (or Calamares shouldn't be using the Qt locale information). The list of country names used to build QLocale data has no spaces in the country names (except for "European Union" and "Outlying Oceania"). It doesn't include accents either, like "Reunion". The list of languages is similarly inconsistent ("NorwegianNynorsk" vs "Western Frisian") and missing accents ("Hawaiian"). So it's something to take up upstream, I think. |
|
QTBUG 32487 (since 2013) |
|
QTBUG-32487 is about pulse audio. https://bugreports.qt.io/browse/QTBUG-34287 is the right one. |
This basically means we talk about localization in the respective localized variant. e.g. "German (Germany)" ➡ "Deutsch (Deutschland)". If geoip lookup failed or isn't configured for whatever reason it's a stretch to expect the user to know english enough to find their own language. Preferring the localized strings resolves this issue. Additionally this happens to bypass calamares#712 respectively https://bugreports.qt.io/browse/QTBUG-34287 as the native names are properly spelled. So, as long as Qt has localized names the names will also be properly spelled.
|
National names seem to be less derpy (at least in Qt 5.9) than the English names, so this has gone away as a side-effect of using the native language and country names. |
|
I'm still seeing this in Lubuntu 18.10 and we have Qt 5.11. Given the date of your comment @adriaandegroot I would presume that Calamares 3.2.2 would be sufficient, but that does not play out that way. What am I missing? |
|
@wxl We have 3.2.1 in Disco as of right now; does this make a difference? |
|
@tsimonq2 I'm confused by your message, as we had 3.2.2 in Cosmic and still do in Disco, though we have some more patches. Problem is still there with 0ubuntu4, which is the latest. |
|
Ah, right. |
|
@adriaandegroot Since I still see this as a problem, can we please reopen this? Or let me know what I'm lacking to see the correct behavior? |
|
It looks like the commit from @apachelogger wasn't actually merged :( |
|
@wxl the country name was fixed in the welcome page, but not in the locale page. @apachelogger 's patch did the latter as well, and I didn't take that over. |
This basically means we talk about localization in the respective localized variant. e.g. "German (Germany)" ➡ "Deutsch (Deutschland)". If geoip lookup failed or isn't configured for whatever reason it's a stretch to expect the user to know english enough to find their own language. Preferring the localized strings resolves this issue. Additionally this happens to bypass #712 respectively https://bugreports.qt.io/browse/QTBUG-34287 as the native names are properly spelled. So, as long as Qt has localized names the names will also be properly spelled.
|
Just wanted to officially confirm this is doing what it's supposed to be doing in 3.2.4. |
When Calamares starts the language list says "English (UnitedStates)" and "English (UnitiedKingdom)" so its seems spaces are missing.
The text was updated successfully, but these errors were encountered: