[timezonewidget] wrong currentZoneImage for Reykjavik

[oberon-manjaro]

Submission type

• [x ] Bug report
• Feature Request

Info regarding which version of Calamares is used, which Distribution

v3.2.0 on Manjaro

description?

Reykjavik, Iceland belongs to timezone UTC+00:00, which is actually depicted correctly on the timezone map. So When locale Atlantic/Reykjavic is selected, timezone GMT should be highlighted.
Instead, the highlight is placed on GST:

[kkofler]

The thing is that Reykjavik does not observe DST (it is always on UTC year round) whereas London observes DST in summer, i.e., it is on UTC+01:00 right now. So they are not really in the same time zone in summer. That said, Iceland should of course be highlighted if the Reykjavik zone is selected.

[oberon-manjaro]

In fact the pin for Reykjavik is displayed too far South, so actually in the wrong zone.

[oberon-manjaro]

Hm. I guess what actually needs to be adjusted is the map. But if you would just move Iceland to where the pin goes, this will place it more south than the tip of Greenland. Looks like our map projection isn't really compatible with the coordinates provided be tzdata there 😉

[oberon-manjaro]

If you look closely you will also find that Copenhagen is practically displayed in Germany and Helsinki somewhere in Estonia or Latvia ...
Since the pin is rather big in relation to the map, maybe we can just use some (non-transparent) blue where about the Reykjavik lovation is displayed. Or maybe a compromise of moving Iceland a bit, plus apply some opacity even more south of that...

[oberon-manjaro]

Moving Iceland just a little bit seems to do the job while still looking geographically acceptable 😉 :

I'll send a PR.

[adriaandegroot]

How timezone selection works:

• the mouse click is transformed into longitude and latitude
• a closest location is found
• timezones are highlighted based on pixel-values in the tz graphics

At some point, the images were resized from their original (openSUSE?) form, which introduced blurring into the images. See, e.g., e0988a5 where I went and fixed it for Amsterdam.

Instead of moving Iceland on the map, there are two things to do:

• fix the transparency of pixels in the timezone that now claims Reykjavik, so that the next timezone over (i.e. the correct one) can claim it.
• fix the mapping of location data to the displayed map. See, e.g., 7803163 for a fix I did earlier that corrected most of Canada's North. It has a comment "math needs work", which hasn't been done yet.

So I'd much prefer fixing the zones / location pins in general (e.g. getting Helsinki right as well) rather than pushing continents around ("Calamares has detected that your computer is in the Triassic period; please click on Gondwanaland for your locale.")

[oberon-manjaro]

Got it! 😆

[adriaandegroot]

Careful testing shows that the mapping of latitude and logitude to locations on the map is not good. Fudged the math a bit, so that things are more accurate -- but the equator still isn't in the right place. Basically this timezone widget selector needs to be re-done, with better images and clearer documentation of what-is-where.