Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent data destruction #1050

Closed
wants to merge 1 commit into from
Closed

Prevent data destruction #1050

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2018

@philmmanjaro
Copy link
Member

@adriaandegroot: what do you think about this PR? For me it looks merge-able ...

@adriaandegroot
Copy link
Contributor

  • needs better commit message
  • contains a bunch of churn
  • the actual effective change is adding -o ro,noload ... that seems sensible, I think

@philmmanjaro
Copy link
Member

@adriaandegroot: I still have to test my approach. @stikonas: do you think it is needed or does the current code we have now in master work already and therefore prevent data loss?

@ghost
Copy link
Author

ghost commented Nov 8, 2018

The current code you have now mounts peoples shit into tmp.
Lotta scripts that run could destroy it. Just because QTemporaryDir doesn't destroy it doesn't mean something else can't. You only need to read the fstab.

@adriaandegroot
Copy link
Contributor

This is in-progress in the fix-partitioning branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philmmanjaro @adriaandegroot