Skip to content

Commit

Permalink
[wpilib] Deprecate MotorController
Browse files Browse the repository at this point in the history
The drive classes no longer need this interface, and it rigidly couples
us to motor controller vendors who only update and do a major release of
their vendordep once per year.

We were originally going to do this in wpilibsuite#6053, but we wanted to gather
feedback on the alternate approach during a season first (as far as I
know, we received none).
  • Loading branch information
calcmogul committed May 22, 2024
1 parent 0c822b4 commit 4d16fc7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ namespace frc {
/**
* Interface for motor controlling devices.
*/
class MotorController {
class [[deprecated(
"This class is being removed with no replacement")]] MotorController {
public:
virtual ~MotorController() = default;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@

import edu.wpi.first.wpilibj.RobotController;

/** Interface for motor controlling devices. */
/**
* Interface for motor controlling devices.
*
* @deprecated This class is being removed with no replacement.
*/
@Deprecated(forRemoval = true, since = "2025")
public interface MotorController {
/**
* Common interface for setting the speed of a motor controller.
Expand Down

0 comments on commit 4d16fc7

Please sign in to comment.