Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reschedule will change the uid in the webhook payload #1551

Closed
buschco opened this issue Jan 18, 2022 · 4 comments · Fixed by #1557 or #1584
Closed

reschedule will change the uid in the webhook payload #1551

buschco opened this issue Jan 18, 2022 · 4 comments · Fixed by #1557 or #1584
Labels
🐛 bug Something isn't working

Comments

@buschco
Copy link
Contributor

buschco commented Jan 18, 2022

Found a bug? Please fill out the sections below. 👍

Issue Summary

A summary of the issue. This needs to be a clear detailed-rich summary.

Steps to Reproduce

  1. Book a appointment (I also tested with secret meetings and with or without metadata)
  2. In the Mail to the appointment open the "Manage booking" link and reschedule the appointment
  3. The BOOKING_RESCHEDULED webhook payload will have a different uid

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

@buschco buschco added the 🐛 bug Something isn't working label Jan 18, 2022
buschco added a commit to buschco/calendso that referenced this issue Jan 18, 2022
@buschco
Copy link
Contributor Author

buschco commented Jan 18, 2022

As a fix, the rescheduleUid could be included in the payload.
I am sure there is a better solution, but this could be a good starting point.
https://github.com/calendso/calendso/pull/1557

@baileypumfleet
Copy link
Contributor

Thanks for reporting this and submitting a PR! Our team will review this as soon as we can

buschco added a commit to buschco/calendso that referenced this issue Jan 20, 2022
buschco added a commit to buschco/calendso that referenced this issue Jan 21, 2022
buschco added a commit to buschco/calendso that referenced this issue Jan 21, 2022
@buschco
Copy link
Contributor Author

buschco commented Feb 7, 2022

I think this issue should be reopened.
I messed up the branch and the wrong thing was merged, so this issue was never addressed in any commit.

#1556 (comment)

@PeerRich PeerRich reopened this Feb 7, 2022
@PeerRich
Copy link
Member

PeerRich commented Feb 7, 2022

I think this issue should be reopened.

I messed up the branch and the wrong thing was merged, so this issue was never addressed in any commit.

#1556 (comment)

@alishaz-polymath

buschco added a commit to buschco/calendso that referenced this issue Feb 17, 2022
zomars pushed a commit that referenced this issue Feb 19, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
zomars pushed a commit that referenced this issue Feb 21, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
3 participants