Busy booked events from CalDav (NextCloud) & Apple don't block scheduling availability

[s-gbz]

Word of praise: Guys, I love Open Source I love your project & I love that you once again demonstrate the world the power of OSS ❤️ 🚀

Summary

This is issue is probably related to #47 #78 #97 #1271 and possibly #1269 .

As described in the title, I conntected my personal calendar via CalDav from a NextCloud instance.
I booked all of January 24th as busy in said calendar & expected Cal to disallow scheduling any further events on this day
-> However, all of the time slots were still free.
I had even checked what the primary calendar was & in which calendar my events should be created in.

At first I suspected this was intentional behaviour. Then I connected my gmail calendar and replayed the scenario
-> Events created in my gmail calendar blocked available time slots in Cal -> As expected!

Demonstration

Snippet of the personal CalDav calendar, note the busy scheduling

Availability displayed in Cal

Steps to Reproduce

1. Connect your calendar via CalDav (mine is pulled from NextCloud) or from Apple (refering to words from my colleague)
2. Schedule some events in your personal calendar that should not be available for booking via Cal
3. Open your booking page & take note that those slots are still available

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

• Browser version:
  • https://www.whatsmybrowser.org/b/NMQEB
  • https://www.whatsmybrowser.org/b/DOL7R
• Node.js version
  • Using your SaaS version
• Further information
  • The german environment of NextCloud couldn't be an issue, right? Like the NextCloud API returning "beschäftigt" instead of "busy", right?
    (The time zones between CalDav & Cal match)

Even further observation

Interestingly enough when I created a specific event at 3pm in my personal calender and double booked an event at this via Cal,
the newly created event is displayed as 3pm in the calendar, but says 2pm when I click on it.

[milospuac]

Thanks for sending this! Our team will investigate further, and I'll give you an update once sorted.

[krzyzanowskim]

on the flip side, my WebDAV (fastmail) entry whatever is marked as free or busy, is always imported as busy.

[alishaz-polymath]

Hi @s-gbz ,

We have since updated the availability module and were hoping to confirm if you still face this issue. 🙏

Also @krzyzanowskim , are you still facing this issue?

[alishaz-polymath]

Just an update on this, we have identified an issue relating to our calendar fetching method using a library where the events created directly on the calendar are not being picked, which would explain this issue. We're trying to sort it out ASAP. 🙏

[s-gbz]

Hey there, @liam-k is actually the one who faced the issue.
Liam can you give it another try?

[zacchiro]

Hey there, @liam-k is actually the one who faced the issue. Liam can you give it another try?

FWIW, I've also faced the issue. But, unless I'm missing something, nothing in this issue log states that something has actually changed in the implementation (and hence much less in the deployment at cal.com), warranting another attempt to double-check things have been fixed.

I'll be happy to conduct such a test when a fix has been committed and deployed at cal.com.
(Please shout if I'm missing the fact that it has already.)

[alishaz-polymath]

Hey @zacchiro
You're spot on. I'm currently fixing this issue among others in #3905 and once it is all set and merged, I'll give you a shout to test it on your end 🙌
The issue is the difference of data structuring and response in various CalDAV servers and the library we use to fetch them(tsdav). I'm trying to create a sanitization module which might help out in most of these cases, but would need proper testing to confirm 🙏

[alishaz-polymath]

Fix merged

[zacchiro]

Has this been deployed in production at cal.com? The ticket is now marked as closed, but I still experience the problem that busy-booked recurrent events from caldav/nextcloud don't block scheduling availability.

Here is a minimal example (which I originally posted by mistake in #2236, sorry!):

BEGIN:VCALENDAR
PRODID:-//Ximian//NONSGML Evolution Calendar//EN
VERSION:2.0
METHOD:PUBLISH
BEGIN:VTIMEZONE
TZID:Europe/Paris
X-LIC-LOCATION:Europe/Paris
BEGIN:DAYLIGHT
TZNAME:CEST
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
DTSTART:19810329T020000
RRULE:FREQ=YEARLY;UNTIL=20370329T010000Z;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
BEGIN:STANDARD
TZNAME:CET
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
DTSTART:19961027T030000
RRULE:FREQ=YEARLY;UNTIL=20361026T010000Z;BYDAY=-1SU;BYMONTH=10
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTAMP:20220823T090621Z
DTSTART;TZID=Europe/Paris:20220830T140000
DTEND;TZID=Europe/Paris:20220830T144500
SEQUENCE:2
ORGANIZER;CN=Stefano Zacchiroli:mailto:*censored*
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;
 CN=*censored*;SCHEDULE-STATUS=2.0:mailto:
 *censored*
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=OPT-PARTICIPANT;PARTSTAT=ACCEPTED;
 CN=*censored*;SCHEDULE-STATUS=2.0:mailto:
 *censored*
SUMMARY:*censored*
LOCATION:*censored*
TRANSP:OPAQUE
RRULE:FREQ=WEEKLY;UNTIL=20221225T130000Z;BYDAY=TU
CLASS:PUBLIC
CREATED:20220824T074516Z
LAST-MODIFIED:20220824T074516Z
RECURRENCE-ID;TZID=Europe/Paris:20220830T140000
END:VEVENT
END:VCALENDAR

[alishaz-polymath]

@zacchiro Hey, thanks for the detailed comment. Can you please confirm if this is a problem with all busy events on Nextcloud or only recurring events, so that we can focus on a specific issue and potentially speed up the resolution?
🙏

[zacchiro]

On Tue, Aug 30, 2022 at 11:36:24PM -0700, Syed Ali Shahbaz wrote: @zacchiro Hey, thanks for the detailed comment. Can you please confirm if this is a problem with all busy events on Nextcloud or only recurring events, so that we can focus on a specific issue and potentially speed up the resolution? 🙏

I'm seeing it only with recurrent events, yes.

[Kovah]

I had this issue with CalDAV and iCloud months ago. Retried today on Cal.com and both calendar integrations do not take into account existing events on the calendars.
Have tried both all-day and time specific events which I added to the calendars, but my Cal.com calendar still shows me as available. Are there any details I could provide?

[alishaz-polymath]

Hey @Kovah did you add the events directly to the calendar or by booking a slot at cal? We’re currently working to resolve an issue where events created directly on the calendars aren’t being picked up. We’ve identified as such for a couple of services, so could you also let us know exactly which service provider you are using? Thanks

[Kovah]

Thanks for the fast reply!
I have created the events in the calendar directly, not booked anything over Cal.com. Providers are Apple iCloud and Mailbox.org (CalDAV).

[alishaz-polymath]

Thank you. I’ll explore this further 🙏

[saschafoerster]

Yeah!