Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-298] Select component needs updating to 2.0 #5315

Closed
ciaranha opened this issue Nov 1, 2022 · 6 comments
Closed

[CAL-298] Select component needs updating to 2.0 #5315

ciaranha opened this issue Nov 1, 2022 · 6 comments
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI
Milestone

Comments

@ciaranha
Copy link
Member

ciaranha commented Nov 1, 2022

This is still very much a v1 component.

CleanShot 2022-11-01 at 11.46.47.gif

Dropdown Menu Brief - ❖ Cal DS (Figma)

The border colour, radius doesn't match v2 designs.

From SyncLinear.com

From SyncLinear.com | CAL-298

@ciaranha ciaranha changed the title [CAL-298] Select component [CAL-298] Select component needs updating to 2.0 Nov 1, 2022
@MatheusBeniniF
Copy link
Contributor

@Jaibles, on this page we already import v2 select, do you want to change the whole component?

@ciaranha
Copy link
Member Author

ciaranha commented Nov 1, 2022

I'll have to take another look. To me it looks like this component has v1 colours and border radius so it's likely the component needs updating yes. Pretty sure this issue is app wide.

@milospuac milospuac added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Nov 1, 2022
@MatheusBeniniF
Copy link
Contributor

updates on that?

@ciaranha
Copy link
Member Author

ciaranha commented Nov 8, 2022

There's been some discussion on the team about this.

I think the outcome is that we're going to try wrestle our current select input to look more like v2. For me that would include:

  • update the height (it's currently 2px too high
  • border colour (uses v1 colours)
  • border radius (should be 6px not 4px)
  • and fix the focus state: currently the text inside the input moves around when focussed

@sean-brydon please let me know if that is not accurate and we have other plans here.

@MatheusBeniniF
Copy link
Contributor

can I do that?

@ciaranha
Copy link
Member Author

I've no objections! If you hit any issues or questions reach out to @sean-brydon perhaps. He's looked into this a little bit I know and warned me that it's perhaps not a task that's as easy as it looks :)

@ciaranha ciaranha added this to the v.3.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI
Projects
None yet
Development

No branches or pull requests

5 participants