Google Cal return 401 if permissions not given #4616
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
approved these changes
Sep 20, 2022
| @@ -38,6 +38,8 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse) | |||
| const token = await oAuth2Client.getToken(code); | |||
|
|
|||
| key = token.res?.data; | |||
|
|
|||
| if (!key) res.status(401).json({ message: "Permissions not granted" }); | |||
There was a problem hiding this comment.
Suggested change
| if (!key) res.status(401).json({ message: "Permissions not granted" }); | |
| if (!key) return res.status(401).json({ message: "Permissions not granted" }); |
emrysal
added a commit
that referenced
this pull request
Sep 20, 2022
* fix isSelectedProp for settings/calendars switches (#4589) * Hotfix/ Embed Tabs (#4593) * Fixing installed app navigation (#4595) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Embed width increase to allow preview to work in desktop mode (#4547) * fixed settings teams rewrite * fixed 404 signup page (#4603) * New Crowdin translations by Github Action (#4599) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * Fix event type navigation (#4565) * Fix event type navigation * Fix dropdown focus styling * Fix border radius * Remove stray classname Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> * typo in /more (#4610) Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> * Return 401 on null keys (#4616) * Fix wrong team link (#4620) * Fixes #4380 (#4615) * fix: positioning of arrows (#4478) Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * Fixes #4606 - Add guests cannot be removed (#4609) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat: animate event list while reordering (#4611) * fix: prevent waiting while invalidating * feat: add auto animate * static postion is added to animation container because auto animate adding a inline style of position relative, which breaks arrow buttons position. * fix: wait until query get cancelled * fix: set querydata correctly Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: alannnc <alannnc@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Leo Giovanetti <hello@leog.me> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Afzal Sayed <14029371+afzalsayed96@users.noreply.github.com> Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: Alex van Andel <me@alexvanandel.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Nafees Nazik <84864519+G3root@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR returns a 401 error when a user is connecting a Google Calendar but does not give the proper permissions. This was creating null credentials and breaking the connected calendars screen.
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist