Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/top banner #5443

Merged
merged 17 commits into from
Nov 15, 2022
Merged

Feat/top banner #5443

merged 17 commits into from
Nov 15, 2022
+135 −11

Conversation

Udit-takkar
Copy link
Contributor

Fixes #5287

Screenshot 2022-11-09 at 7 15 26 PM

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 11:38PM (UTC)

@Udit-takkar Udit-takkar marked this pull request as draft November 9, 2022 13:48
@what-the-diff
Copy link

what-the-diff bot commented Nov 9, 2022

  • Added a new component called TopBanner
  • Updated the Shell to render this banner at the top of every page in our app
  • The banner is dismissable and can be used for any type of warning or error message that needs to be displayed across all pages in our application (e.g., "We are experiencing an outage")

@Udit-takkar
Copy link
Contributor Author

Screenshot 2022-11-09 at 8 40 47 PM

@emrysal @zomars
Update packages/ui/components/topbanner/TopBanner.tsx
4802af3 
Co-authored-by: Omar López <zomars@me.com>
@Udit-takkar Udit-takkar added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Nov 14, 2022
@Udit-takkar Udit-takkar removed the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Nov 14, 2022
zomars
zomars approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and approved since I need this component for another PR. Thanks again @Udit-takkar 🙏🏽

LGTM

@zomars zomars marked this pull request as ready for review November 14, 2022 23:13
@zomars zomars merged commit 4fef7ba into main Nov 15, 2022
@zomars zomars deleted the feat/top-banner branch November 15, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal left review comments

@sean-brydon sean-brydon sean-brydon left review comments

@zomars zomars zomars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-287] Create top banner component
5 participants
@Udit-takkar @emrysal @zomars @sean-brydon @PeerRich