New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds setDate function. Fixes issue #2 #3
Conversation
} | ||
} | ||
|
||
public func setDate(withDate date: Date) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer updateDate(to date: Date)
} | ||
|
||
public func setDate(withDate date: Date) { | ||
if pickersAreSetUp { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the pickersAreSetUp
property is necessary here. Instead, I think we should change setup(withInitiallySelectedDate:) to just
setup()and add a call to
setup()from
init`.
Thanks for working on this! |
Thank you for the review. |
I made changes as you wanted. Please let me know if any concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thank you for this useful repo. |
Hi,
I tried to touch the code as little as possible. Please let me know if any problems/improvements.
Rare