Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setDate function. Fixes issue #2 #3

Merged
merged 3 commits into from Oct 22, 2019
Merged

Conversation

@Reza-Rajabi
Copy link

Reza-Rajabi commented Oct 21, 2019

Hi,
I tried to touch the code as little as possible. Please let me know if any problems/improvements.

Rare

}
}

public func setDate(withDate date: Date) {

This comment has been minimized.

Copy link
@calda

calda Oct 21, 2019

Owner

I'd prefer updateDate(to date: Date)

}

public func setDate(withDate date: Date) {
if pickersAreSetUp {

This comment has been minimized.

Copy link
@calda

calda Oct 21, 2019

Owner

I don't think the pickersAreSetUp property is necessary here. Instead, I think we should change setup(withInitiallySelectedDate:) to just setup()and add a call tosetup()frominit`.

@calda

This comment has been minimized.

Copy link
Owner

calda commented Oct 21, 2019

Thanks for working on this!

@Reza-Rajabi

This comment has been minimized.

Copy link
Author

Reza-Rajabi commented Oct 22, 2019

Thank you for the review.
I will change them.

@Reza-Rajabi

This comment has been minimized.

Copy link
Author

Reza-Rajabi commented Oct 22, 2019

I made changes as you wanted. Please let me know if any concerns.

@calda
calda approved these changes Oct 22, 2019
Copy link
Owner

calda left a comment

Thank you!

@calda calda merged commit a19fe8c into calda:master Oct 22, 2019
@Reza-Rajabi

This comment has been minimized.

Copy link
Author

Reza-Rajabi commented Oct 22, 2019

Thank you for this useful repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.