-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adoptedStyleSheets#push doesn't work #124
Comments
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124 Fixes #16956
Any news on this? The PR has been waiting for a while now. |
The PR wasn't passing on OSX (I believe @Lodin uses Windows for development). I don't have a ton of open source time any more with family responsibilities and a new job, but I'll try to take a look at polishing up the PR listed this weekend. Or, if you're so inclined, feel free to clone the PR branch and modify it to make it work for OSX. Once that's ready, I'm happy to get the feature merged and released. |
I'd love to see what I can do, can I run the CI stuff locally tho? Or does the ready-configured CI come with the fork? https://github.com/calebdwilliams/construct-style-sheets/actions/runs/5200387008/job/14098414752?pr=126 reports |
The CI basically just runs the test suite. You can find the steps in the |
Any ideas? |
Looks like there's some re-writing that will need to happen. I'll try to look in the next few days, but I'm fairly swamped and don't have a ton of open source time these days. |
Full output on macOS for Looks like Safari already checks for invalid invocations itself, and is throwing a different error. You can make the tests pass if you weaken the assertion, and only check that the invocation fails, rather than for the exact error message. There's also some
|
Describe the bug
document.adoptedStyleSheets.push(new CSSStyleSheet()); doesn't work.
To Reproduce
Apply CSSStyleSheet via push
Expected behavior
document.adoptedStyleSheets = [ new CSSStyleSheet() ];
document.adoptedStyleSheets.push(new CSSStyleSheet());
should have the same effect
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: