fix: Theme injection in Safari with polyfill #16954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
Artur-
force-pushed
the
safari-with-polyfill
branch
from
e313c1a
to
af93e80
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mshabarov
approved these changes
Jun 5, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124
Artur-
pushed a commit
that referenced
this pull request
Jun 5, 2023
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124 Fixes #16956
|
This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polyfill does not support push or splice, see calebdwilliams/construct-style-sheets#124