Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

How to prevent HTML escaping #3

Closed
Lloople opened this issue Mar 8, 2019 · 2 comments
Closed

How to prevent HTML escaping #3

Lloople opened this issue Mar 8, 2019 · 2 comments

Comments

@Lloople
Copy link
Contributor

Lloople commented Mar 8, 2019

First of all, thank you for this amazing package 🙌

I'm already using it in my personal website. The process was smooth and the result is really great.

The only issue I'm having is when I try to embed tweets. You can check it here

I searched for a while but can't find anything useful. Maybe it's not even possible.

I already have the allowIframe option set to true.

Thank you,

David

@calebporzio
Copy link
Owner

Ah yes, I only escape "iframes" not "script" tags. I'd be open to a pull request where we change the option (or add one) to: "allowDangerousTags" that allows "scripts" "iframes" and I forget the other ones GitHub escapes.

Is this something you'd be interested in contributing?

@Lloople
Copy link
Contributor Author

Lloople commented Mar 9, 2019

Sure!

I’ll check it out tomorrow 👍

Maybe it could be a list of dangerousTagsAllowed default to iframe and script 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants