Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The webpage doesn't handle 500 errors from the API #238

Closed
rberrelleza opened this issue Jun 4, 2021 · 2 comments
Closed

The webpage doesn't handle 500 errors from the API #238

rberrelleza opened this issue Jun 4, 2021 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@rberrelleza
Copy link
Contributor

Found a bug? Please fill out the sections below. 👍

Issue Summary

When the API returns a 500 error, the "event calendar" page doesn't handle the error. Instead, it keeps 'loading' forever.

image

(the 500 was due to a configuration issue with my google oauth app it seems)

Technical details

  • Browser version: chrome
  • Node.js version: 14
  • Anything else that you think could be an issue.
@rberrelleza rberrelleza added the 🐛 bug Something isn't working label Jun 4, 2021
@baileypumfleet
Copy link
Contributor

This shows as loading because at the start of the code, we tell the UI to show the loading spinner, and as the code errors out, we don't execute the line of code that stops the spinner.

This will just need to be a try catch or something that checks that an integration is added and show an appropriate error dependent on that.

KATT pushed a commit that referenced this issue Sep 3, 2021
@dependabot @kodiakhq
Bump prisma from 2.20.0 to 2.20.1 (#238)
8a4a0b5 
Bumps [prisma](https://github.com/prisma/prisma) from 2.20.0 to 2.20.1.
- [Release notes](https://github.com/prisma/prisma/releases)
- [Changelog](https://github.com/prisma/prisma/blob/master/docs/releases.md)
- [Commits](prisma/prisma@2.20.0...2.20.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@baileypumfleet
Copy link
Contributor

The app now displays a proper error when we receive an error from the API call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rberrelleza @baileypumfleet