Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow regex flags/parameters in regexp_instr and calling tests #245

Closed
tconbeer opened this issue Mar 3, 2023 · 1 comment · Fixed by #247
Closed
Labels
enhancement New feature or request

Comments

@tconbeer
Copy link
Contributor

tconbeer commented Mar 3, 2023

Is your feature request related to a problem? Please describe.
I would like the regex I provide to expect_column_values_to_match_regex_list and similar tests to be case-insensitive, but currently that is not possible.

Postgres, Snowflake, and Redshift support an argument (called flags in pg and parameters in the others) for this. BigQuery does not, but the column could be lowercased before being passed into regexp_instr.

Describe the solution you'd like
Add a flags argument to expect_column_values_to_match_regex_list and other regex-based tests that accepts a string value and passes it through to the underlying database implementation.

Describe alternatives you've considered
Rolling my own test.

Additional context
I'm happy to contribute this if there is interest.

@tconbeer tconbeer changed the title [Feature Request] Allow regex parameters in regexp_instr and calling tests [Feature Request] Allow regex flags/parameters in regexp_instr and calling tests Mar 3, 2023
@clausherther
Copy link
Contributor

@tconbeer Thanks for this feature request! This seems like a useful and worthwhile addition, happy to take any PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants