Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Effects don't fade over time #14

Closed
sylae opened this issue May 25, 2013 · 1 comment
Closed

Status Effects don't fade over time #14

sylae opened this issue May 25, 2013 · 1 comment
Labels

Comments

@sylae
Copy link
Contributor

sylae commented May 25, 2013

Original author: GarbageB...@gmail.com (May 24, 2010 14:06:45)

What steps will reproduce the problem?

  1. Start a game
  2. Become affected by a status effect. (Poison, webbed, bless, haste,
    probably all of 'em that are supposed to fade with time.)
    3.

What is the expected output? What do you see instead?
The effects of Bless don't diminish and disappear, as with poison and
haste. Only after being completely webbed (Player must clean webs message
in combat) will the webs get cleaned, and it's only on that turn. The Stand
Ready action doesn't clean them like it should.

What version of the product are you using? On what operating system?
Classic BoE build 30.04.2010
Win XP
Please provide any additional information below.

Original issue: http://code.google.com/p/openexile/issues/detail?id=24

@sylae
Copy link
Contributor Author

sylae commented May 25, 2013

From overmenshin@yahoo.co.uk on May 25, 2010 23:43:04
Indeed, i've found that during a previous attempt at merging Mac and Windows code
(revision 121), a previously removed function was reintroduced (short move_to_zero
(short ...)) overwriting the template move_to_zero function Ormus (apparently) wrote
for short types.
That was effectively preventing the function from working right (it was supposed to
return the result) and every action requiring moving a short type to zero (as the
one you mentioned : bless, haste, poison, cleaning ...) was not happening.
(idem with the minmax template, but minmax was working nonetheless )

An updated code is already uploaded and, given the severity of the bug (which is
present since 1.1; a quite late report for a game stopping bug :/), i'll release an
updated executable as well.

Thanks for your contribution,
Chokboyz

@sylae sylae closed this as completed May 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant