Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEDs should generally contain their label text #297

Open
CelticMinstrel opened this issue Jan 6, 2023 · 0 comments
Open

LEDs should generally contain their label text #297

CelticMinstrel opened this issue Jan 6, 2023 · 0 comments
Labels
dialogxml Affects the dialog system work Non coding related task

Comments

@CelticMinstrel
Copy link
Member

The dialog engine in the original game didn't have any association between an LED button and its label text. The LED button was just a button, and the label text was just an unrelated static text.

Associating them however adds the nice feature that you can click the label text to activate the button. So, I'd like to update as many dialogs as possible to do this.

#274 and #273 notes a number of dialogs that could use the treatment. There may be more, and some of those might not merit it.

@CelticMinstrel CelticMinstrel added dialogxml Affects the dialog system work Non coding related task labels Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialogxml Affects the dialog system work Non coding related task
Projects
None yet
Development

No branches or pull requests

1 participant