Items are wiped when loading a save file.

[NQNStudios]

On Linux, when I create a new party in-game, save, close the game, open it and load the party, they won't have any items.

The same goes for opening any party in the character editor.

[CelticMinstrel]

This bug is quite mystifying. As far as I can tell, it goes wrong right here:

cboe/src/fileio/fileio_party.cpp

Line 271 in f083965

real_univ = std::move(univ);

But how it can possibly go wrong there, I've yet to figure out.

[NQNStudios]

I put a breakpoint on that line and the debugger didn't stop at it. Maybe that's not where it goes wrong?

[NQNStudios]

Ah the breakpoint worked when I put in on the corresponding line in the v2 function.

[NQNStudios]

More specifically, it goes wrong when the adventurers array is swapped, like we talked about on IRC:

cboe/src/universe/party.cpp

Line 167 in 32f24b4

swap(lhs.adven, rhs.adven);

In my debugger when I open the party, I'm actually finding that a breakpoint on that line triggers TWICE. The first time, items are preserved. The second time, they get wiped. Are we expecting it to be called twice?

(Edit: I'm using this debugger Watch expression to monitor the items: univ.party.adven[0]->items[0])

[CelticMinstrel]

Fixed in #328.