Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fleet: add fleet update command. #390

Merged
merged 1 commit into from
Apr 14, 2023
Merged

fleet: add fleet update command. #390

merged 1 commit into from
Apr 14, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Apr 13, 2023 •
edited
Loading

Summary of this proposal

Add the missing update command for fleet management.

Notes for the reviewer

This is essential for test calyptia/core-fluent-bit#38.

Issue(s) number(s)

Checklist for submitter

  • My PR has a related issue/bug number.
  • My PR provides tests
    • Integration tests are added/passes
    • Unit tests are added/passes
    • End-to-end tests added/passes
    • Static code check added/passes
    • Linting on documentation added/passes
    • Does not affect code coverage stats
  • My PR requires updating dependencies
  • My PR has the documentation changes required.

Checklist for reviewer

  • The proposal fixes a bug/issue or implements a new feature that is well described.
  • The proposal has sufficient test cases that covers the changes.
    • If changes an API, it does not break backwards compatibility (-1 major version).
  • If integration is required, the proposal has integration tests.
  • The proposal does not break coverage stats
  • The proposal has the required documentation changes.

Backport

  • Backport to the latest stable release.

@pwhelan
fleet: add fleet update command.
2c72ee0 
Signed-off-by: Phillip Whelan <phil@calyptia.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pwhelan pwhelan requested a review from niedbalski April 13, 2023 04:09
@niedbalski niedbalski merged commit 7ea16ad into main Apr 14, 2023
@niedbalski niedbalski deleted the fleet-update branch April 14, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niedbalski niedbalski niedbalski approved these changes

@jasmingacic jasmingacic Awaiting requested review from jasmingacic

@nicolasparada nicolasparada Awaiting requested review from nicolasparada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwhelan @niedbalski