Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Completion, insert and replace when there is something after the cursor #55

Closed
apupier opened this issue Apr 27, 2018 · 3 comments
Closed
Assignees

Comments

@apupier
Copy link
Member

apupier commented Apr 27, 2018

for instance, there is "timer", I put the cursor after the t and choose twitter

current result is:
"twitter:kindimer"

expected result would be:
"twitter:kind"

same applies for options.

How to handle the remaining parts if more complex such as:
"timer:value?delay=1000"
if I autocomplete after the t with twitter:kind, what would be the result?
"twitter:kind"
"twitter:kind?delay=1000"
"twitter:value"

@lhein lhein self-assigned this Aug 14, 2018
@lhein
Copy link
Collaborator

lhein commented Aug 14, 2018

This is a client side behaviour from what I found out. In Eclipse it is controlled by Settings for Java but for XML there seems to be no setting at all. For VSCode I haven't checked yet.

@apupier
Copy link
Member Author

apupier commented Aug 14, 2018

this can be done on server side with the textEdit parameter https://microsoft.github.io/language-server-protocol/specification
image

lhein added a commit to lhein/camel-language-server that referenced this issue Aug 22, 2018
lhein added a commit to lhein/camel-language-server that referenced this issue Sep 4, 2018
lhein added a commit to lhein/camel-language-server that referenced this issue Sep 5, 2018
lhein added a commit to lhein/camel-language-server that referenced this issue Sep 5, 2018
lhein added a commit to lhein/camel-language-server that referenced this issue Sep 6, 2018
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein added a commit to lhein/camel-language-server that referenced this issue Sep 6, 2018
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
apupier referenced this issue in apupier/camel-language-server Sep 6, 2018
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
lhein added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
lhein pushed a commit that referenced this issue Sep 6, 2018
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@tsedmik
Copy link
Member

tsedmik commented Sep 27, 2018

verified with master branch

@tsedmik tsedmik closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants