Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XrmMockGenerator.Control doesn't expose static methods #9

Closed
daryllabar opened this issue Apr 3, 2018 · 0 comments
Closed

XrmMockGenerator.Control doesn't expose static methods #9

daryllabar opened this issue Apr 3, 2018 · 0 comments
Labels

Comments

@daryllabar
Copy link
Collaborator

XrmMockGenerator.Control.createString generates a compile error since it is an instance, and doesn't expose the static methods

daryllabar added a commit that referenced this issue Apr 3, 2018
AutoLookupControl.Mock.ts
- Simplified Constructor/Property defintion
- Made uiKeyPressableOptional

UiStandardElement.Mock.ts
- Added factory create method to simplify creation.

Attribute.ts
- Reordered the properties of createString.  This is a breaking change, but it allows for just being able to specify Attribute.createString("lastname"), rather than being forced to populated all of the parameters.  The order of the parameters have been updated to be in the most like order of setting the value.  (i.e. many unit tests may be setting a control to visible, or enabling it.  Very few will care about the format, and even fewer will be worry about the label or setting the maxLength.

control.ts
- The xrm-mock-generator has exposed an instance of Control, making the static methods impossible to call.  Ideally, it makes more sense for the class to be static methods, but the attribute class was setup as an instance, and I elected to leave it.  Not sure if it should be changed or not.

Added test for the control being added with a label
camelCaseDave pushed a commit that referenced this issue Oct 19, 2020
Pull from my master to dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants