Capstone 1 project #3
Conversation
Index.html was splitted between home (index.html) and about (about.html) section. Besides, the main program section was created inside de home webpage.
Logos and titles were customised
There was a problem hiding this comment.
Hi @Camilovelag,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request ⚠️
- You have submitted a project that has failing linters, Kindly make sure your linters are all passing before submitting the PR.
ESLint AutoFix
- if you have a lot of ESLint line errors, I kindly suggest you fix them by running
npx eslint . --fixon your command line, but please get used to fixing the errors line by line also because it'll help you learn best practices.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @topeogunleye in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
This reverts commit 71f21d2.
Bootstrap 5 was installed again using cdn links instead compilled files
|
I solved the ESlinter problem using cdn links to install Bootstrap 5 in my project instead compiled files 🧰 |
There was a problem hiding this comment.
Hello @Camilovelag 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 🎉 🎉 🎉 🎉
Cheers and Happy coding!👏👏👏
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <img class="img-ratio mx-3" src="./assets/icons/facebook-icon.png" alt=""> | ||
| </a> | ||
| <a href="https://twitter.com/motorbikeexpo?lang=en" class="" target="_blank" rel="noopener noreferrer"> | ||
| <img class="img-ratio mx-3" src="./assets/icons/twitter-icon.png" alt=""> |
There was a problem hiding this comment.
- [OPTIONAL] Please kindly add alt text to all images to make your website accessible
Good morning/afternoon. 🌤️
This pull request is intended to complete capstone #1.
Changes made: 🔧
✔️ Tools were installed (linterns and bootstrap 5).
✔️ Index.html and about.html were created.
✔️ Webpage was styled.
✔️ Toggle menu was added.
✔️ Speaker card section was created dynamically using scripts.js
✔️ Images, logos, and icons were customized.
Currently, I have an issue with the ESlinter related to the Bootstrap 5 js files because they are reporting errors, but if you see the error report, there is nothing related to the scripts.js file (my js file) as you can see in the image below (you could check out searching my file in the ESlinter Error Report):
I mention this not because I want to skip this error. In fact, I'm asking for your help because I wasn't able to reach out for help at this time (people I know haven't enough experience working on that, and I could find working solutions on the internet).
Of course, I am aware this PR won't be approved, but I hope to get help from you and to know additional feedback to improve my project and be approved in the second CR.
I am expected for feedback.
Regards! 😸