-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To Do list: add & remove #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Camilovelag ,
Status: APPROVED π₯³ π₯³
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! π
Highlights
- Linters are passing βοΈ
- README is descriptive π
- Great job with your design and functionalities π
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Good day! π€οΈ
This pull request is intended to refactor the "Awesome books" project to use classes.
It is powered @Camilovelag.
π οΈ Changes made
βοΈ Remove all hardcoded items from the tasks array.
βοΈ Create a new JavaScript file for the new functionality.
βοΈ Implement a function for adding a new task (add a new element to the array).
βοΈ Implement a function for deleting a task (remove an element from the array).
βοΈ Implement a function for editing task descriptions.
βοΈ By default new tasks have the property
completed
set tofalse
and the propertyindex
set to the value of the new array length.βοΈ Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique.
βοΈ All changes to the To Do List should be saved in local storage.
I'm expecting feedback.
Regards! πππ