Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: add & remove #2

Merged
merged 13 commits into from
Sep 29, 2022
Merged

To Do list: add & remove #2

merged 13 commits into from
Sep 29, 2022

Conversation

Camilovelag
Copy link
Owner

Good day! 🌀️

This pull request is intended to refactor the "Awesome books" project to use classes.
It is powered @Camilovelag.

πŸ› οΈ Changes made

βœ”οΈ Remove all hardcoded items from the tasks array.
βœ”οΈ Create a new JavaScript file for the new functionality.
βœ”οΈ Implement a function for adding a new task (add a new element to the array).
βœ”οΈ Implement a function for deleting a task (remove an element from the array).
βœ”οΈ Implement a function for editing task descriptions.
βœ”οΈ By default new tasks have the property completed set to false and the property index set to the value of the new array length.
βœ”οΈ Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique.
βœ”οΈ All changes to the To Do List should be saved in local storage.

I'm expecting feedback.

Regards! πŸ‘πŸ‘πŸ‘

done

Copy link

@Ugboaja-Uchechi Ugboaja-Uchechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Camilovelag ,

Status: APPROVED πŸ₯³ πŸ₯³

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights

  • Linters are passing βœ”οΈ
  • README is descriptive πŸ‘
  • Great job with your design and functionalities πŸ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Camilovelag Camilovelag merged commit adaff36 into main Sep 29, 2022
@Camilovelag Camilovelag deleted the Add-remove branch September 29, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants