Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if it actually is 4D #13

Open
haesleinhuepf opened this issue Apr 23, 2022 · 3 comments
Open

Check if it actually is 4D #13

haesleinhuepf opened this issue Apr 23, 2022 · 3 comments

Comments

@haesleinhuepf
Copy link
Contributor

haesleinhuepf commented Apr 23, 2022

I'm just creating an issue to keep track of this: There are many occurrences of this in the code:

 #TODO: Check if it actually is 4D

https://github.com/BiAPoL/napari-stress/blob/bef2a68a8f5937a535f62f06f04c16daad7e5cdb/src/napari_stress/_utils.py#L188
https://github.com/BiAPoL/napari-stress/blob/bef2a68a8f5937a535f62f06f04c16daad7e5cdb/src/napari_stress/_utils.py#L193
https://github.com/BiAPoL/napari-stress/blob/decorator-for-timelapse/src/napari_stress/_utils.py#L204

I guess it's related to

I just created this issue so that we don't loose track of this

@jo-mueller
Copy link
Member

Thanks for creating this issue.

I think the time-slicer has solved this in a quite clever manner by simply converting all images to 4D images under the hood. How would this look like for other layer types?

  • Surface: I think such a conversion should be relatively easy for surfaces because surfaces do not really exist in 2D, hence we can directly see by the dimension of the array of vertices whether we are looking at 3D or 4D
  • Points: The tricky part here is the question: How does a 2D + t points layer differ from a 3D points layer? A weak distinction could be given by the datatype of the first dimension: The "time coordinates" will always be integers, whereas z-coordinates will likely be float values
  • Vectors: has not been brought up much but I guess it works similarly like the Points layer.

@jo-mueller
Copy link
Member

Interesting mention on this issue here

@jo-mueller
Copy link
Member

PR #18 should have solved this - but additional tests are necessary to ensure correct functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants