Add timelapse decorator for points and surfaces #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported fit functions from _utils submodule
Made converter class public refactored converter class
Closed
|
@haesleinhuepf @zoccoler @Cryaaa any feedback is much appreciated! |
The time_slicer turns all images to 4D images so that three scale parameters are always right.
…ns-to-napari-hook-implementation Expose timelapse decorated functions to napari hook implementation
4 tasks
We're iterating over frames here :)
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
bumped version
removed __main__
haesleinhuepf
approved these changes
May 25, 2022
There was a problem hiding this comment.
Hi Johannes @jo-mueller ,
just minor things. Mostly comments about internal functions, so feel free to ignore my suggestions. I just wrote down what I thought while reading the code. If I misunderstood something, also comment could help. Feel free to merge this anyway.
Best,
Robert
…ps://github.com/BiAPoL/napari-stress into add-timelapse-decorator-for-points-and-surfaces
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
Co-authored-by: Robert Haase <haesleinhuepf@users.noreply.github.com>
…ps://github.com/BiAPoL/napari-stress into add-timelapse-decorator-for-points-and-surfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a more concise version of #10 . It adds some functionality specifically to process Points and Surfaces in 4D.
Features:
TimeLapseConverterclass (napari_stress.TimeLapseConverter()) allows to convert data between a list format (which is handy for processing) and a single data object (which can be handled by Napari)frame_by_frame(napari_stress.frame_by_frame) decorator can be applied to functions that apply one or multiple arguments of napari layer types, currently supported arePointsData,SurfaceData,LabelsData,LayerDataTuple.Fixes #11