-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decorator for timelapse #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Johannes @jo-mueller ,
I was commenting here instead of #11 because it's more convenient to comment on code in PRs than in issues.
So this looks all very cool! I could imagine though that making something like a general Converter class + some specific PointConverter, etc may make sense.
Best,
Robert
- Added frame_by_frame decorator - changed imafge variable name
- also removed nppas alias functions
Only a rising edge should be discovered
This reverts commit ca7efda.
This reverts commit a1c6b3d.
This reverts commit df7bbe4.
This reverts commit 67bfa17.
This reverts commit dd38737.
This reverts commit 0e17126.
This reverts commit 3148c3a.
This reverts commit 7649279.
I put them there for debugging
Function return depends on whether keywords were provided
To whom it may concern @haesleinhuepf @zoccoler @Cryaaa , I made quite a few changes to the code according to the suggestion above. A few notes to ease oversight:
|
@jo-mueller, I don't know how feasible it is to use the time slicer functionality (or the concepts behind it) for points and surfaces. I really like the way 2D data is dealt with (t, z = 1, y, x), since this keeps things very uniform. Furthermore, the time slice will (soonish) have a version which directly generates a lazily loaded 4D dataset as a result. Maybe that would be something interesting? If you want to have a chat about 4D processing and approaches I'd be down :) |
Hi @Cryaaa , Thanks for the Feedback. The original idea of this improvement was to create a simple version of the time slicer that would work with 4D points/surface data because the "real" timeslicer is currently not able to do this and I really need this sort of functionality for this project. I hope it's possible to merge this with the real timeslicer somewhere down the road. I'll try to split this into several PRs so that it becomes clearer what is happening where. |
I'm closing this PR to be continued in a more concise thread PR #18 |
This PR adds a decorator that allows running functions on 4D points/surfaces/labels/etc.
Features
napari.types.ImageData
,LabelsData
,PointsData
orSurfaceData
, it selects a suitable function to convert such 4D data to a list of 3D datasets which can then be processed frame by frameImageData
,SurfaceData
, etc), the resulting list of 3D data is converted to a single 4D data object.Currently supported:
Open issues:
The conversion functions for 4D -> 3D should check whether the data actually is 4D (or 3D or 2D) and handle this somehow. For this data, however, it works for now.
Tests
Functions are tested to a certain degree, but only very weakly.