Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose timelapse decorated functions to napari hook implementation #20

Conversation

jo-mueller
Copy link
Member

This PR fixes the conflict between the napari plugin declaration and some of the time slicer's functionality for the napari_stress.rescale() function

@jo-mueller
Copy link
Member Author

jo-mueller commented May 11, 2022

Also (partially) addresses #13

Copy link
Contributor

@zoccoler zoccoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works here and tests look good. Just a minor comment for a 2D example.

The time_slicer turns all images to 4D images so that three scale parameters are always right.
@jo-mueller
Copy link
Member Author

jo-mueller commented May 13, 2022

It works here and tests look good. Just a minor comment for a 2D example.

@zoccoler Would you mind merging it if it works? :)

@zoccoler zoccoler merged commit f417175 into add-timelapse-decorator-for-points-and-surfaces May 16, 2022
@zoccoler
Copy link
Contributor

Just noticed that tests on Github are failing because of the time limit available for tests.

@jo-mueller jo-mueller deleted the expose-timelapse-decorated-functions-to-napari-hook-implementation branch May 16, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants