admin_only property is not considered for fields in relationships

[arnaud-morvan]

c2cgeoform/c2cgeoform/schema.py

Line 22 in ed621dc

excludes_user = self._get_fields_with_property(self._ADMIN_ONLY)

_get_fields_with_property only return top level excludes which is good because sub level excludes should be mixed with overrides parameters like this :
overrides : {
'myrelationname' : excludes: {...}}

[tsauerwein]

_get_fields_with_property only return top level excludes which is good because sub level excludes should be mixed with overrides parameters

So you are ok with the current behavior?

I see three solutions on how to deal with this problem that the admin_only property is only taken into account for fields on the main model:

1. It's not a bug, it's a feature. If the user wants to exclude fields for child models, he/she has to set 'overrides'. Which is confusing in my opinion.
2. Check for the admin_only recursively and and set the excludes with the overrides property for child models when creating the schema. The problem is that the user might provide a custom overridesobject, so we would have to merge the user overrides with our overrides. This might be tricky but doable.
3. Remove the admin_only property. The user would have to specify the includes or excludes via the overrides property. This also allows to hide fields in the user views.

Opinions welcome!

[tsauerwein]

We agreed to go for option 3, because it should be possible to use the same model with different schemas. And because this is also the way you would do it when directly using ColanderAlchemy.