Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print-Window : Negative values in Orientation-Field #3755

Closed
svareg opened this issue Apr 12, 2018 · 3 comments
Closed

Print-Window : Negative values in Orientation-Field #3755

svareg opened this issue Apr 12, 2018 · 3 comments
Assignees
Milestone

Comments

@svareg
Copy link
Contributor

svareg commented Apr 12, 2018

In the Print-Window, we can configure the orientation of the map for printing. There is a slider and a number-field. But we cannot manually set negative numbers in the number-field, cause only numbers are allowed. So when we try to insert a value that begins with the char "-", the field will remain unchanged.
(Actually we can add the char "-" before the orientation value, but not replace the whole field with "-" alone)

This can be reproduced here : https://geomapfish-demo.camptocamp.net/2.2/

To correct this, I wanted to activate the allowInvalid option on the input.
But because of issues with HTML5 constraint validation, we cannot use input[type=number] with allowInvalid. See: https://docs.angularjs.org/api/ng/input/input%5Bnumber%5D

I think a text-input should be used here, so that the character "-" will be allowed.

If further information is needed please see https://github.com/camptocamp/baselstadt_mapbs/commit/5d65f61fe3b6897ad6a3b78afc39710f72b87d6a

@ger-benjamin
Copy link
Member

ger-benjamin commented Apr 12, 2018

Hello,
Which browser do you use ? (browser and version).
(I can't reproduce it with my chromium.)

@svareg
Copy link
Contributor Author

svareg commented Apr 12, 2018

Hello Benjamin,

Can be reproduced with Firefox 52.0.1, IE 11.0.9600.18952 and Chrome 63.0.3239.84

To reproduce it you just have to select the whole text in the text-box (default there is only a 0), and try to replace it with "-".
2018-04-12 16_47_02-desktop-applikation

I think this doesn't work, cause '-' is not a number and the validation fails.

Hope this helps.

@fredj
Copy link
Member

fredj commented May 16, 2018

fixed with #3802

@fredj fredj closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants