Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to resolve environment variables in yaml config #240

Merged
merged 4 commits into from
May 10, 2022
Merged

Add ability to resolve environment variables in yaml config #240

merged 4 commits into from
May 10, 2022

Conversation

Giaco9
Copy link
Contributor

@Giaco9 Giaco9 commented May 9, 2022

Goal:
Allow resolving environment variables in the yaml config file

Done:

Call os.ExpandEnv before unmarshal the yaml file

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 55.762% when pulling f39d5c0 on Giaco9:fill-yaml-config-with-environment into 06ff551 on camptocamp:master.

hbollon
hbollon approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@hbollon hbollon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(golangci workflow seems broken, runs locally successfully)

@hbollon hbollon merged commit a857bcd into camptocamp:master May 10, 2022
@hbollon
Copy link
Member

hbollon commented May 10, 2022

Thanks for your well made contribution @Giaco9
I will make a new release soon with your addition 👍

@Giaco9 Giaco9 deleted the fill-yaml-config-with-environment branch May 12, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbollon hbollon hbollon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Giaco9 @coveralls @hbollon @giacomo-ca