Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'MultiTaskTrainingArguments' object has no attribute 'uniform_mt_sampling' #2

Closed
heatxg opened this issue Apr 11, 2021 · 7 comments
Assignees

Comments

@heatxg
Copy link

heatxg commented Apr 11, 2021

It looks like there are arguments (percent_of_max_data_size & uniform_mt_sampling) missing that are consumed by the MultiTaskTrainer for the __len__ method.

if self.args.uniform_mt_sampling:

This is causing errors in some of the super methods.
https://github.com/huggingface/transformers/blob/b42586ea560a20dcadb78472a6b4596f579e9043/src/transformers/trainer.py#L367

I've traced them through the repo but found only this reference and do not see them listed in the cl args.

How would you suggest mitigating?

@CAMTL CAMTL assigned CAMTL and Am1n3e and unassigned CAMTL Apr 13, 2021
@CAMTL
Copy link
Owner

CAMTL commented Apr 13, 2021

@heatxg Thank you for bringing this to us. I'm taking a look

@Am1n3e
Copy link
Collaborator

Am1n3e commented Apr 13, 2021

@heatxg I have make a fix in this branch Am1n3e-bugfix-add-missing-args. However, I don't have the time to test it.
Can you give a try and let me know if that fixes your issue ?

@heatxg
Copy link
Author

heatxg commented Apr 13, 2021

@Am1n3e Thank you for taking the time to look into this. I will give the fix a test this evening and update you.

@heatxg
Copy link
Author

heatxg commented Apr 14, 2021

@Am1n3e This got us past the original missing args but now we are stuck at another missing arg

elif self.args.uncert_batch:

@CAMTL
Copy link
Owner

CAMTL commented Apr 14, 2021

@heatxg Thank for getting back to me. I will check it and come back to you!

@Am1n3e
Copy link
Collaborator

Am1n3e commented May 6, 2021

@heatxg I will take a look at the issue this week (I was a bit busy).

@jpilaul
Copy link
Collaborator

jpilaul commented Jun 30, 2021

This issue is fixed in #3

@jpilaul jpilaul closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants