Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Fixes #${283} #284

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

luca-waldmann-cimt
Copy link
Contributor

@luca-waldmann-cimt luca-waldmann-cimt commented Dec 7, 2022

Fixes #283 (which I created myself).

Proposed Changes

  • Add optional argument customRootCert to oAuth (TLS certificate as Buffer)
  • Use the certificate for the call to the OAuth URL
  • Add section in the README describing this argument

Please feel free to edit anything, as I might not have thought about everything. I don't have any previous experience with Typescript.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022

CLA assistant check
All committers have signed the CLA.

@akeller akeller requested a review from jwulf December 13, 2022 23:05
Copy link
Member

@jwulf jwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes all tests. Thanks!

@jwulf jwulf merged commit 9938457 into camunda-community-hub:master Jan 25, 2023
@barmac
Copy link
Contributor

barmac commented Apr 18, 2023

At camunda/camunda-modeler, we recently encountered the problem which this PR solved. Shouldn't the client pick up the certificates from customSSL option automatically? Now I have to provide my organization's root cert in two different config fields even though it's all about the same thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth does not work when the token URL uses self-signed TLS certificates
4 participants