Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom SSL certificate for oAuth connection #3554

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Apr 12, 2023

Before this fix, we did not pass certificates to the oauth config
which is separated from customSSL.

Related to https://github.com/camunda-community-hub/zeebe-client-node-js#oauth

This popped up via SUPPORT-15807

Before this fix, we did not pass certificates to the oauth config
which is separated from customSSL.

Related to https://github.com/camunda-community-hub/zeebe-client-node-js#oauth
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 12, 2023
@barmac barmac requested review from a team, marstamm, smbea and philippfromme and removed request for a team and marstamm April 12, 2023 13:44
@barmac
Copy link
Contributor Author

barmac commented Apr 12, 2023

How I verified this:

Screen.Recording.2023-04-12.at.15.58.25.mov

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nikku nikku added this to the M64 milestone Apr 18, 2023
@barmac barmac merged commit d971376 into master Apr 19, 2023
@barmac barmac deleted the fix-oauth-cert branch April 19, 2023 06:58
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants