User Task Forms UI and data fetching #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
saig0
requested changes
Jan 18, 2023
There was a problem hiding this comment.
@SebastianStamm nice work. 🤩
I found a few issues ❌ that we should fix. And I added some comments with optional suggestions 🔧. Please have a look. 🍪
fix: user tasks with custom/external forms no longer fail to load feat: user tasks without forms can no longer be failed
|
@saig0 Great findings, thanks! The bootstrap tooltip behavior stumped me a bit because there was another problem that the tooltip did not appear at all when the user clicked the reload button when the button was already visible. I think bootstrap got confused because a new element was created that had the same id as the old one. Using the classname as selector fixed it though. I fixed the issues and applied your suggestions with the latest commit, please have look. |
saig0
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way user task forms get their form markup and variables and replaces the previous hacky implementation with the proper one, getting the data from Zeeqs thanks to camunda-community-hub/zeeqs#284
It also changes the complete job UI for user tasks, adding a dedicated form icon and removing the fail and error options from the dropdown because they are not valid options for a user task (for now).
Related issues
closes #10