Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forking-conditions rule #6

Merged
merged 6 commits into from Oct 4, 2019
Merged

Add forking-conditions rule #6

merged 6 commits into from Oct 4, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Sep 13, 2019 •
edited

This is a work-in-progress PR that adds support for forking conditions as described in #5.

TODO

  • Polish documentation
  • Add example diagrams

Closes #5

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 13, 2019
@nikku nikku mentioned this pull request Sep 13, 2019
Closed
@philippfromme philippfromme added the help wanted Extra attention is needed label Sep 23, 2019
@philippfromme
Copy link
Contributor

Can someone using Linux try to generate the docs images using npx @bpmn-io/bpmnlint-generate-docs-images . I'm having issues trying to run it using Windows.

@nikku
Copy link
Member Author

nikku commented Oct 4, 2019

Updated the PR with the generated images.

philippfromme
philippfromme approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@merge-me merge-me bot merged commit 5efc840 into master Oct 4, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 4, 2019
@nikku nikku deleted the 5-forking-conditions branch October 4, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved Conditional Flow Rule
2 participants
@nikku @philippfromme