-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parser warning for intermediate catch timer event with a time cycle #3943
Comments
Hi @Bragolgirith, Thank you for reaching out to us with this. Best regards, |
Hi @yanavasileva ,
Specifically, I would like to use a timer intermediate catch event and set the timer using a cron expression. (This already works great with a time cycle, except for the warning that is being logged.)
Using an expression is indeed an option, but it can quickly get complicated for certain schedules, e.g. "at 10:00 o'clock but not on the weekend", which are trivial to setup with cron. |
Hi @Bragolgirith, Thank you for your patience with this and elaborating further. We agree that a warning message can be too invasive when you have such scenario. What do you think? Are you willing to make a contribution on the log level change? Best, |
Sure, I can take a stab at it after the holidays. |
… with a time cycle - changes the log level entry from Warning to Info for intermediate catch timer event with a time cycle related to camunda#3943
… with a time cycle - changes the log level entry from Warning to Info for intermediate catch timer event with a time cycle related to camunda#3943
… with a time cycle - changes the lint warning for intermediate catch timer event with a time cycle to an INFO level log related to camunda#3943
… with a time cycle - changes the "lint" warning for intermediate catch timer event with a time cycle to an INFO-level log related to camunda#3943
… with a time cycle - update the logged message to contain the process definition key - clean up the unit test related to camunda#3943
switch the log level entry from Warning to Info for intermediate catch timer event with a time cycle related to #3943
The fix will be part of Camunda 7.21 and can be tested with the next alpha release scheduled for February. |
switch the log level entry from Warning to Info for intermediate catch timer event with a time cycle related to #3943
Environment (Required on creation)
Any
Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)
The BpmnParse class currently logs a warning for intermediate catch timer events with a time cycle:
The warning makes sense in isolation (since a cycle is repeating, while a catch event is caught once), however there is currently at least one valid use-case for doing this, see camunda/camunda-modeler#792:
Until there's a convenient way to specify such a
cron
timer without a time cycle, I'd argue that the warning should be removed.Steps to reproduce (Required on creation)
Observed Behavior (Required on creation)
A Warning is logged:
Expected behavior (Required on creation)
A Info message is logged instead.
Root Cause (Required on prioritization)
So far a Warning message is logged when an intermediate catch timer event with a time cycle is modelled. A use case exist where cron timer is better suited for a intermediate catch timer event.
Solution Ideas
Hints
Links
Breakdown
Pull Requests
Dev2QA handover
The text was updated successfully, but these errors were encountered: