Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce restartedByBatch(batchId) filter criteria for historic process instance query #4212

Open
3 tasks
Tracked by #4201
yanavasileva opened this issue Mar 22, 2024 · 1 comment
Open
3 tasks
Tracked by #4201

Introduce restartedByBatch(batchId) filter criteria for historic process instance query #4212

yanavasileva opened this issue Mar 22, 2024 · 1 comment
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.

Comments

@yanavasileva
Copy link
Member

yanavasileva commented Mar 22, 2024 •
edited
Loading

Acceptance Criteria (Required on creation)

  • Extend the historic process instance query (HistoricProcessInstanceQuery) with #restartedByBatch(String batchId) filter criteria
    • filter historic process instances that has an old process instance which is related to job log related to the restart batch
  • Expose changes in REST API
    • document in OpenAPI

Hints

  • query idea: SELECT from ACT_HI_PROCINST RES join ACT_HI_JOB_LOG JL where JL.batchId = param.batchId and RES.restarted_proc_inst_id =JL.PROCESS_INSTANCE_ID_ - there will be more than one job log use the “exists” structure
  • Code:
    • org.camunda.bpm.engine.history.HistoricProcessInstanceQuery
    • engine\src\main\resources\org\camunda\bpm\engine\impl\mapping\entity\HistoricProcessInstance.xml
    • org.camunda.bpm.engine.rest.dto.history.HistoricProcessInstanceQueryDto
  • ❓ HPI supports OR queries, can/do we want the filter be supported for both AND and OR queries?
  • Add to javadoc hint for: If there’s a performance issue, the user needs to clean up their history tables.

Links

Breakdown

Pull Requests
Beta Give feedback
No tasks being tracked yet.
@yanavasileva yanavasileva added type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI labels Mar 22, 2024
@yanavasileva yanavasileva mentioned this issue Mar 22, 2024
Open
1 task
@yanavasileva yanavasileva changed the title Introduce startedByBatch filter criteria for historic process instance query Introduce restartedByBatch(batchId) filter criteria for historic process instance query Mar 27, 2024
@punitdarira
Copy link
Contributor

I am working on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@punitdarira @yanavasileva