Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4214 restarted process instance #4420

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

punitdarira
Copy link
Contributor

@punitdarira punitdarira commented Jun 8, 2024

Related to #4214

@mboskamp
Copy link
Member

Hey @punitdarira, thanks for contributing! Feel free to mark this PR as "Ready for review" when you are done with it and want someone from the team to review the changes. 👍

@mboskamp mboskamp removed their assignment Jun 20, 2024
@psavidis
Copy link
Contributor

Hey @punitdarira,
How is the progress going with this Pull Request? Are you still interested to work on it? If not, no worries, you can always open a new one in the future.

@punitdarira
Copy link
Contributor Author

Hey @punitdarira, How is the progress going with this Pull Request? Are you still interested to work on it? If not, no worries, you can always open a new one in the future.

Hi @mboskamp, @psavidis,
This PR is slightly dependent on #4334 for tests
I though of creating common tests for this and above mentioned PR.
I tested this feature locally and it was working as expected.
Currently I am working on the dependent ticket.

@punitdarira punitdarira marked this pull request as ready for review June 27, 2024 01:03
@punitdarira
Copy link
Contributor Author

  • Need to add the add column sql in db/upgrade. I wasn't sure how the naming of the file works.

@punitdarira
Copy link
Contributor Author

Hi! @mboskamp @psavidis,
This PR is ready to review. I updated existing test cases itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants