Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose restartedProcessInstanceId for historic process instances #4214

Closed
2 tasks done
Tracked by #4201
yanavasileva opened this issue Mar 22, 2024 · 5 comments
Closed
2 tasks done
Tracked by #4201

Expose restartedProcessInstanceId for historic process instances #4214

yanavasileva opened this issue Mar 22, 2024 · 5 comments
Assignees
@psavidis
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:feature Issues that add a new user feature to the project. type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0-alpha6 version:7.22.0

Comments

@yanavasileva
Copy link
Member

yanavasileva commented Mar 22, 2024 •
edited by psavidis
Loading

Acceptance Criteria (Required on creation)

Hints

Links

Breakdown

Pull Requests
Beta Give feedback
  1. 4214 restarted process instance #4420
    ci:all-as
    punitdarira
  2. 4214 - PR for Triggerring the CI #4593
    ci:all-db ci:default-build ci:rest-api
    psavidis
@yanavasileva yanavasileva added type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI labels Mar 22, 2024
@yanavasileva yanavasileva mentioned this issue Mar 22, 2024
Open
1 task
@yanavasileva yanavasileva changed the title Expose oldProcessInstanceId for historic process instances Expose restartedProcessInstanceId for historic process instances Mar 27, 2024
@punitdarira
Copy link
Contributor

I am working on this one

punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue May 23, 2024
@punitdarira
feat(engine): Adding new field of restartedProcessInstanceId in history
cd2b513 
related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue May 24, 2024
@punitdarira
feat(engine): Adding new column of RESTARTED_PROC_INST_ID_
9b32af3 
related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue May 24, 2024
@punitdarira
feat(engine): Adding new column of RESTARTED_PROC_INST_ID_
3d96fff 
related to camunda#4214
@punitdarira
Copy link
Contributor

Hi Yana,
Since we are setting the property of restartedProcessInstanceId through StartProcessInstancesCmd, I think we can go ahead by setting it in StartProcessInstanceAtActivitiesCmd too.
This way even the instances created through /process-definition/{id}/restart will have the property set.
I am guessing the restart flow will never go through StartProcessInstancesCmd at least in the community edition as there is a validation of not null instructions.

This reminds me we need to update the documentation of /process-definition/{id}/restart. It says the field of instructions and instanceId is optional but in the code it validates for not null.

@yanavasileva
Copy link
Member Author

yanavasileva commented May 27, 2024 •
edited
Loading

Hi @punitdarira,

Good catch, only StartProcessInstanceAtActivitiesCmd matters for the restart batch operation so I will adjust the description. Thank you!

This reminds me we need to update the documentation of /process-definition/{id}/restart. It says the field of instructions and instanceId is optional but in the code it validates for not null.

If it's not a big change, feel free to incorporate it to one of your contributions or raise a task for it.

Best,
Yana

punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 2, 2024
@punitdarira
feat(engine): Setting restartedProcessInstanceId
3e87e13 
related to camunda#4214
@mboskamp mboskamp mentioned this issue Jun 10, 2024
Merged
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 26, 2024
@punitdarira
feat(engine): Added create and drop indexes cmd. Update unit test
d700465 
related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 26, 2024
@punitdarira
feat(engine): Added restartedInstanceId field in /history/process-ins…
812dbb4 
…tance response

related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 26, 2024
@punitdarira
feat(engine): Unit test for new field of restartedProcessInstanceId
17aaf73 
related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Jun 27, 2024
@punitdarira
feat(engine): Documentation and unit tests
6091b7b 
related to camunda#4214
@psavidis psavidis self-assigned this Sep 6, 2024
@tasso94 tasso94 added version:7.22.0 type:feature Issues that add a new user feature to the project. labels Sep 6, 2024
@tasso94
Copy link
Member

tasso94 commented Sep 6, 2024

Hey @psavidis,

It would be great to complete what @punitdarira already started and get it into the 7.22.0 release.

Best,
Tassilo

punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Sep 10, 2024
@punitdarira
Delete engine/src/main/resources/org/camunda/bpm/engine/db/create/act…
db4fdb0 
…iviti.cockroachdb.create.history.sql

Related to camunda#4214
punitdarira added a commit to punitdarira/camunda-bpm-platform that referenced this issue Sep 10, 2024
@punitdarira
Delete engine/src/main/resources/org/camunda/bpm/engine/db/drop/activ…
06798f8 
…iti.cockroachdb.drop.history.sql

Related to camunda#4214
@psavidis psavidis mentioned this issue Sep 10, 2024
Closed
psavidis added a commit that referenced this issue Sep 10, 2024
@psavidis
chore(engine): Add Column and Index to Migration Scripts
f03855b 
Related-to: #4214
psavidis pushed a commit that referenced this issue Sep 12, 2024
@punitdarira
feat(engine, engine-rest): Expose restartedProcessInstanceId
0509c7b 
Context: This commit introduces restartedProcessInstanceId for historic process instances.
Why: To be able to track the originating process instances in restart - batch operations.

Db-Migration: The commit introduces

- RESTARTED_PROC_INST_ID_ column in ACT_HI_PROCINST table
- ACT_IDX_HI_PRO_RST_PRO_INST_ID index on the above

Unit-tests: Adds a unit test for verified the population of the column for completed and restarted process instances

Related-to

- #4214
- #4201
@psavidis
Copy link
Contributor

@punitdarira fork is merged to master. Thank you for your kind contribution.
Closing this ticket.

hauptmedia added a commit to hauptmedia/operaton that referenced this issue Nov 4, 2024
@hauptmedia
feat(engine, engine-rest): Expose restartedProcessInstanceId
731e32d 
Context: This commit introduces restartedProcessInstanceId for historic process instances.
Why: To be able to track the originating process instances in restart - batch operations.

Db-Migration: The commit introduces

- RESTARTED_PROC_INST_ID_ column in ACT_HI_PROCINST table
- ACT_IDX_HI_PRO_RST_PRO_INST_ID index on the above

Unit-tests: Adds a unit test for verified the population of the column for completed and restarted process instances

Related-to

- camunda/camunda-bpm-platform#4214
- camunda/camunda-bpm-platform#4201

Backported commit 0509c7b114 from the camunda-bpm-platform repository.
Original author: punitdarira <punitdarira@gmail.com>
@hauptmedia hauptmedia mentioned this issue Nov 4, 2024
Merged
javahippie pushed a commit to operaton/operaton that referenced this issue Nov 5, 2024
@hauptmedia @javahippie
feat(engine, engine-rest): Expose restartedProcessInstanceId
db0f12d 
Context: This commit introduces restartedProcessInstanceId for historic process instances.
Why: To be able to track the originating process instances in restart - batch operations.

Db-Migration: The commit introduces

- RESTARTED_PROC_INST_ID_ column in ACT_HI_PROCINST table
- ACT_IDX_HI_PRO_RST_PRO_INST_ID index on the above

Unit-tests: Adds a unit test for verified the population of the column for completed and restarted process instances

Related-to

- camunda/camunda-bpm-platform#4214
- camunda/camunda-bpm-platform#4201

Backported commit 0509c7b114 from the camunda-bpm-platform repository.
Original author: punitdarira <punitdarira@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psavidis psavidis

Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:feature Issues that add a new user feature to the project. type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0-alpha6 version:7.22.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tasso94 @punitdarira @yanavasileva @psavidis