CMMN diagram deployment

[zambrovski]

In the same way you can deploy a process diagram together with the process definition, it is reasonable to deploy a case diagram together with case definition. There is an important reason to do so now, since it is basic to case management based on CMMN to be able to see the diagram of the notation.

From the technical point of view, the change is very similar to the what is done on the BPMN part. The CmmnDeployer writes an additional field called diagramResourceName. This field is added to the myBatis mappings, statements and table definitions. The mechanisms of loading and saving resource is essentually there. In order to retrieve the diagram for the case, the repository service has been extended. In addition, a GetDeploymentCaseDiagramCmd provides the ability to retrieve the InputStream which is used the REST Api. This has been extended by a /case-definition/{id}/diagram and case-definition/key/{key}/diagram methods in order to access the case diagram.

I expect this feature as essential BEFORE 7.2 final, since CMMN customers are willing to see the diagrams of the new language. The plugin under development would load the image stored together with the case definition.

I would be happy to be able to contribute it. What do you think?

[buildhive]

camunda BPM » camunda-bpm-platform #996 SUCCESS
This pull request looks good
(what's this?)

[jangalinski]

+1, we are building a showcase and discussed "key features" we need to provide to convince project managers to consider ACM and visualization was clearly among them.

[zambrovski]

Just detected a small mistake. Fixed it in fc39e3a

[zambrovski]

I also fixed the sql migration scripts.

[buildhive]

camunda BPM » camunda-bpm-platform #997 SUCCESS
This pull request looks good
(what's this?)

[buildhive]

camunda BPM » camunda-bpm-platform #998 SUCCESS
This pull request looks good
(what's this?)

[meyerdan]

Hi Simon

Awesome, thanks.

I created a Jira isue for this: https://app.camunda.com/jira/browse/CAM-3004
More feedback later.

Daniel

[ThorbenLindhauer]

Hi Simon,

Thanks for your pull request which I have reviewed this morning. Before merging, I would like to ask you for two things:

1. You included the case diagram resource name in the CaseDefinitionQuery SQL statements and the Impl class but did not expose this in the interface. Since we do not have the same functionality in the ProcessDefinitionQuery, I would suggest removing this unused code for now.
2. Could you please undo the automated(?) code formatting, especially in RepositoryService and RepositoryServiceImpl? That would be the "final" modifiers for the parameters, the @OverRide annotations and the automated formatting of the method comments. We try to keep the coding style as consistent as possible.

Thank you!

Have a nice weekend,
Thorben

[buildhive]

camunda BPM » camunda-bpm-platform #1016 SUCCESS
This pull request looks good
(what's this?)

[ThorbenLindhauer]

Thanks for making the changes and providing this pull request altogether.
I just merged it: b3cb030

[zambrovski]

Cool!