New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAM-13811: feat(quarkus): use a separate camunda thread pool #1571
Conversation
9dadd6d
to
adae746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general 👍 Please see my suggestions below:
.../runtime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/ManagedJobExecutor.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/ManagedJobExecutor.java
Outdated
Show resolved
Hide resolved
...ntime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/CamundaEngineRecorder.java
Outdated
Show resolved
Hide resolved
.../runtime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/ManagedJobExecutor.java
Show resolved
Hide resolved
...me/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/CamundaJobExecutorConfig.java
Outdated
Show resolved
Hide resolved
...me/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/CamundaJobExecutorConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing...
...ntime/src/main/java/org/camunda/bpm/quarkus/engine/extension/impl/CamundaEngineRecorder.java
Outdated
Show resolved
Hide resolved
* Use a ThreadPoolExecutor instead of the Quarkus core thread pool Executor for the Camunda JobExecutor. * Refactor the JobExecutor configuration properties to generic ones that are always up-to-date with the process engine changes. Related to CAM-13811
aeda424
to
a94b523
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things...
Related to CAM-13811