Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAM-13811: feat(quarkus): use a separate camunda thread pool #1571

Merged
merged 5 commits into from Aug 19, 2021

Conversation

koevskinikola
Copy link
Member

Related to CAM-13811

@koevskinikola koevskinikola self-assigned this Aug 16, 2021
@koevskinikola koevskinikola force-pushed the CAM-13811-quarkus-camunda-thread-pool branch from 9dadd6d to adae746 Compare August 17, 2021 10:25
@koevskinikola koevskinikola marked this pull request as ready for review August 18, 2021 07:13
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍 Please see my suggestions below:

Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing...

* Use a ThreadPoolExecutor instead of the Quarkus core thread pool
  Executor for the Camunda JobExecutor.
* Refactor the JobExecutor configuration properties to generic ones that
  are always up-to-date with the process engine changes.

Related to CAM-13811
@koevskinikola koevskinikola force-pushed the CAM-13811-quarkus-camunda-thread-pool branch from aeda424 to a94b523 Compare August 18, 2021 14:23
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things...

@koevskinikola koevskinikola merged commit bdf683b into master Aug 19, 2021
@koevskinikola koevskinikola deleted the CAM-13811-quarkus-camunda-thread-pool branch August 19, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants